This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 976
Webview crash on YouTube after a while of inactivity #9663
Labels
Milestone
Comments
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jun 23, 2017
Resolves brave#9663 Auditors: @bsclifton Test Plan: - covered with unittests
8 tasks
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Jun 23, 2017
Resolves brave#9663 Auditors: @bsclifton Test Plan: - covered with unittests
bsclifton
added a commit
that referenced
this issue
Jun 23, 2017
Adds null checks to tabContentState
bsclifton
added a commit
that referenced
this issue
Jun 23, 2017
Adds null checks to tabContentState
bsclifton
added a commit
that referenced
this issue
Jun 23, 2017
Adds null checks to tabContentState
Still seeing webview crash on pages after some inactivity for a while, but no error in console cc: @bsclifton @NejcZdovc |
Yeah this is something that I was talking about. I only added null checkers so that we don't get in to the state where you have |
I've been unable to repro this on macOS; will try on Windows next |
I'm going to close this issue as the original reported issue is indeed fixed (ex: no errors showing in the browser console). I've spent about 20 minutes trying to repro the dead tab issue (which should be logged as a separate issue) on both macOS and Windows and have not been successful |
This was referenced Jun 26, 2017
Not seeing any webview crash on YouTube on 0.17.9 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Webview crash on YouTube after a while of inactivity
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA):
Brave 0.17.6 upgraded from 0.17.4
rev 30a3eee
Muon 4.1.2
Steps to reproduce:
Actual result:
Webview crash on YouTube after a while of inactivity
Expected result:
Should not crash
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Found on upgrade from previous build
Is this an issue in the currently released version?
Not sure
Can this issue be consistently reproduced?
Not sure
Extra QA steps:
1.
2.
3.
Screenshot if needed:
![image](https://user-images.githubusercontent.com/17010094/27441589-e93e7b8e-5765-11e7-9614-aa6311434820.png)
Console Error
Any related issues:
The text was updated successfully, but these errors were encountered: