Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Webview crash on YouTube after a while of inactivity #9663

Closed
srirambv opened this issue Jun 22, 2017 · 5 comments
Closed

Webview crash on YouTube after a while of inactivity #9663

srirambv opened this issue Jun 22, 2017 · 5 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jun 22, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Webview crash on YouTube after a while of inactivity

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.17.6 upgraded from 0.17.4
    rev 30a3eee
    Muon 4.1.2

  • Steps to reproduce:

    1. Open any YouTube video
    2. Pause the video and background the tab for a while
    3. Switch to the tab to continue playing, Web view crash on the tab, Trying to type in URL causes webview crash can make webview take over full UI #8574
  • Actual result:
    Webview crash on YouTube after a while of inactivity

  • Expected result:
    Should not crash

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Found on upgrade from previous build

  • Is this an issue in the currently released version?
    Not sure

  • Can this issue be consistently reproduced?
    Not sure

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    Console Error
    image

  • Any related issues:

@srirambv srirambv added this to the 0.17.x (Beta Channel) milestone Jun 22, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 23, 2017
Resolves brave#9663

Auditors: @bsclifton

Test Plan:
- covered with unittests
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 23, 2017
Resolves brave#9663

Auditors: @bsclifton

Test Plan:
- covered with unittests
bsclifton added a commit that referenced this issue Jun 23, 2017
Adds null checks to tabContentState
bsclifton added a commit that referenced this issue Jun 23, 2017
Adds null checks to tabContentState
bsclifton added a commit that referenced this issue Jun 23, 2017
Adds null checks to tabContentState
@srirambv
Copy link
Collaborator Author

Still seeing webview crash on pages after some inactivity for a while, but no error in console
image

cc: @bsclifton @NejcZdovc

@srirambv srirambv reopened this Jun 23, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 23, 2017

Yeah this is something that I was talking about. I only added null checkers so that we don't get in to the state where you have null for the frame. But I don't know (didn't do any research) why is webview crashing.

@NejcZdovc NejcZdovc removed their assignment Jun 23, 2017
@bsclifton
Copy link
Member

I've been unable to repro this on macOS; will try on Windows next

@bsclifton bsclifton self-assigned this Jun 23, 2017
@bsclifton
Copy link
Member

I'm going to close this issue as the original reported issue is indeed fixed (ex: no errors showing in the browser console).

I've spent about 20 minutes trying to repro the dead tab issue (which should be logged as a separate issue) on both macOS and Windows and have not been successful

@srirambv
Copy link
Collaborator Author

Not seeing any webview crash on YouTube on 0.17.9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.