Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

handle sync DELETE history/bookmark records with empty objects #9308

Closed
diracdeltas opened this issue Jun 7, 2017 · 0 comments · Fixed by #9349
Closed

handle sync DELETE history/bookmark records with empty objects #9308

diracdeltas opened this issue Jun 7, 2017 · 0 comments · Fixed by #9349
Assignees
@diracdeltas
Labels
feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.18.x Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 7, 2017 •
edited by luixxiul

Test plan

#9349 (comment)

browser-laptop should accept DELETE records of the following form, otherwise it is not able to properly handle DELETE records sent by Android:

{
      action: 2,
      objectId: [...],
      deviceId: [...],
      bookmark: {}
}

This only applies to history/bookmarks, not siteSettings. (siteSetting DELETEs specify fields to be deleted instead of deleting the entire object)

cc @SergeyZhukovsky @jhreis
@diracdeltas diracdeltas added this to the 0.18.x milestone Jun 7, 2017
@diracdeltas diracdeltas self-assigned this Jun 7, 2017
diracdeltas added a commit that referenced this issue Jun 9, 2017
@diracdeltas
handle empty objects in sync DELETEs
2fe768c 
fix #9308
@diracdeltas diracdeltas mentioned this issue Jun 9, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Jun 12, 2017
@diracdeltas
handle empty objects in sync DELETEs
1a5e0b0 
fix #9308
diracdeltas added a commit that referenced this issue Jun 12, 2017
@diracdeltas
handle empty objects in sync DELETEs
91ef559 
fix #9308
@diracdeltas diracdeltas mentioned this issue Jun 12, 2017
Closed
diracdeltas added a commit that referenced this issue Jun 12, 2017
@diracdeltas
follow ups to fix for #9308
52bbcaf 
fix #9405
fix #9404
diracdeltas added a commit that referenced this issue Jun 13, 2017
@diracdeltas
Merge pull request #9407 from brave/fix/9308-followup
91465de 
follow ups to fix for #9308
diracdeltas added a commit that referenced this issue Jun 13, 2017
@diracdeltas
Merge pull request #9407 from brave/fix/9308-followup
d63759b 
follow ups to fix for #9308
diracdeltas added a commit that referenced this issue Jun 26, 2017
@diracdeltas
re-fix #9308
33b83c7
diracdeltas added a commit that referenced this issue Jun 26, 2017
@diracdeltas
Revert "handle empty objects in sync DELETEs"
720ecc4 
This reverts commit 91ef559.

it also re-fixes #9308 after the revert and fixes handling of skipSync (#111)

Test Plan:
Test plan in brave/sync#111
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

handle empty objects in sync DELETEs, refactor DELETE code brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @LaurenWags