Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

sync records are sent twice #9404

Closed
diracdeltas opened this issue Jun 12, 2017 · 0 comments · Fixed by #9407
Closed

sync records are sent twice #9404

diracdeltas opened this issue Jun 12, 2017 · 0 comments · Fixed by #9407
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jun 12, 2017 •
edited by luixxiul

i accidentally ignored the skipSync field in #9308

test plan:

  1. start pyramid 0
  2. sync pyramid 1 to pyramid 0
  3. add some bookmarks to pyramid 1, wait for pyramid 0 to fetch the bookmarks
  4. Open chrome-extension://cjnmeadmgmiihncdidmfiabhenbggfjm/_generated_background_page.html
  5. in the console, you should not see pyramid 0 sending the bookmarks that it just fetched
@diracdeltas diracdeltas added this to the 0.18.x (Frozen, only critical adds from here) milestone Jun 12, 2017
@diracdeltas diracdeltas self-assigned this Jun 12, 2017
@diracdeltas diracdeltas changed the title sync records are created twice sync records are sent twice Jun 12, 2017
diracdeltas added a commit that referenced this issue Jun 12, 2017
@diracdeltas
Fix sync-after-import-bookmark hierarchy
3ea1f8f 
Fix #8892
Fix #9405
Fix #9404
@diracdeltas diracdeltas mentioned this issue Jun 12, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Jun 12, 2017
@diracdeltas
follow ups to fix for #9308
52bbcaf 
fix #9405
fix #9404
@diracdeltas diracdeltas mentioned this issue Jun 12, 2017
Merged
8 tasks
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

follow ups to fix for #9308 brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @LaurenWags