Close tab page is not working

[NejcZdovc]

Test plan

#11311 (comment)

---

• Did you search for similar issues before submitting this one?
  yes

• Describe the issue you encountered:
  Close tab page is not working

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS

• Brave Version (revision SHA):
  7ce06ee

• Steps to reproduce:

  1. Set tab page limit to 6
  2. Open 10 tabs (new tabs)
  3. Try to close active tab page

• Actual result:
  Nothing happens

• Expected result:
  Tabs from current tab page should be closed

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  yes

• Is this an issue in the currently released version?
  yes

• Can this issue be consistently reproduced?
  yes

[NejcZdovc]

This is not working because this function returns false for new tab, blank tab and private tab. We need to change this back, so you can close tabs tab page without any restrictions.

This was introduced in commit f4283c0#diff-e12cc9b3579286a186d0f0c82dfa8186R66

cc @bridiver

[luixxiul]

Updated the manual test plan: https://github.com/brave/browser-laptop/wiki/Manual-Tests/_compare/3eee18b5675c6a06aa5bd614d6b6f9d1ace7768e...13895aa7fab6ae3af8d7c84a7a6565b5b4fec2d1

CC @LaurenWags @alexwykoff @srirambv

[bsclifton]

This was working for me when I tested #9414. Is this still an issue, @NejcZdovc?

[NejcZdovc]

Yes it's still an issue, as reported in #9609 as well

[luixxiul]

If the tab page has two tabs, about:preferences and the new tab, clicking Close tab page only closes the about page, leaving the new tab opened.

[bsclifton]

Is this the same issue as #9722? (I didn't see any errors mentioned in the above comments)

[NejcZdovc]

@bsclifton no it's not the same.
@bridiver why did we added this part (so that about:newtab is ignored) f4283c0#diff-e12cc9b3579286a186d0f0c82dfa8186R66?

[bridiver]

@NejcZdovc it wasn't added, it was moved from f4283c0#diff-f5a0b45b8323a469e78cf98fb0c49b8fL632

[NejcZdovc]

@bridiver you are correct. It was introduced here #6570 by me 😄 Not sure why I added it and why it was working before.

[bsclifton]

cc @NejcZdovc for comment
Per conversation, he is saying this is happening ONLY for about:newtab because there is an if statement (or something to be discovered)

[bbondy]

0.19.x: 511bf20
0.20.x: 7bb5286
master: bf4726d