Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

opening lots of tabs via "ctrl+t" and quickly closing them using "ctrl+w" created dead tabs #10905

Closed
kjozwiak opened this issue Sep 12, 2017 · 4 comments
Assignees
Labels
bug feature/keyboard-shortcuts priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release-notes/include stale

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Sep 12, 2017

Test plan

#11311 (comment)


- Did you search for similar issues before submitting this one?

Yes

- Describe the issue you encountered:

When opening large quantities of tabs using "ctrl+t" and than quickly closing them using "ctrl+w", you'll sometimes get "dead" tabs that cannot be closed or used. If you manage to create a lot of these dead tabs, "ctrl+w" eventually stops working.

The UI is still responsive and the user can always restart so it's not as bad as #9083.

- Platform (Win7, 8, 10? macOS? Linux distro?):

macOS 10.12.16 x64 - Reproduced
Win 10 x64 - Reproduced

- Brave Version (revision SHA):

Brave 0.18.33

- Steps to reproduce:

  1. Open Brave and start creating a lot of tabs via "ctrl+t"
  2. Once you have a page or two worth of tabs, quickly switch over and start pressing "ctrl+w"

- Actual result:

Some of the tabs will become "dead" and cannot be closed or used. Going through the above STR, you'll sometimes manage to create ~10 dead tabs. When this happens, "ctrl+w" stops working.

- Expected result:

Tabs should be easily created and closed without creating dead tabs. When this happens, "ctrl+w" shouldn't break and should always work as expected.

- Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes

- Is this an issue in the currently released version?

Yes

- Can this issue be consistently reproduced?

Yes

- Screenshot if needed:

deadtabs

@kjozwiak kjozwiak added this to the 0.20.x (Developer Channel) milestone Sep 12, 2017
@alexwykoff alexwykoff assigned alexwykoff and bbondy and unassigned alexwykoff Sep 19, 2017
@ghost ghost added the priority/P3 Major loss of function. label Sep 26, 2017
bbondy added a commit that referenced this issue Oct 6, 2017
@bbondy
Copy link
Member

bbondy commented Oct 6, 2017

0.19.x: 511bf20
0.20.x: 7bb5286
master: bf4726d

@srirambv
Copy link
Collaborator

srirambv commented Oct 6, 2017

No dead tabs but causes crash(#11322)

@srirambv
Copy link
Collaborator

Found one dead tab when opened a lot of tabs(5 tab pages) holding Ctrl+T and closing tabs(4 tab pages) by holding down Ctrl+W.
11322
11322-1

@srirambv srirambv reopened this Dec 20, 2017
@srirambv
Copy link
Collaborator

Same single dead tab on 0.20.8 as well

@alexwykoff alexwykoff removed the priority/P3 Major loss of function. label Jan 9, 2018
@alexwykoff alexwykoff modified the milestones: 0.20.x (Beta Channel), 0.22.x (Nightly Channel) Jan 9, 2018
@alexwykoff alexwykoff added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Jan 9, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@alexwykoff alexwykoff modified the milestones: 0.23.x (Nightly Channel), Backlog (Prioritized) Mar 13, 2018
@bsclifton bsclifton added the stale label Sep 3, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/keyboard-shortcuts priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release-notes/include stale
Projects
None yet
Development

No branches or pull requests

7 participants