Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

History inside autocomplete suggestions cannot be cleared until the browser is closed #9736

Closed
luixxiul opened this issue Jun 27, 2017 · 11 comments
Closed

History inside autocomplete suggestions cannot be cleared until the browser is closed #9736

luixxiul opened this issue Jun 27, 2017 · 11 comments
Assignees
@NejcZdovc
Labels
bug feature/autocomplete feature/history feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 27, 2017 •
edited
Loading

Test plan

#10795 (comment)

Describe the issue you encountered: History inside autocomplete suggestions cannot be cleared until the browser is closed.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Debian

  • Brave Version (revision SHA): 0.17.10

  • Steps to reproduce:

    1. Clear the browser's profile
    2. Go to :g brave
    3. Clear the data via Clear browsing data inside History
    4. Enter brave to the URL bar

  • Actual result:

    clipboard01

  • Expected result: the history should be cleared before you restart the browser

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul added this to the 0.19.x (Nightly Channel) milestone Jun 29, 2017
@bsclifton
Copy link
Member

cc: @bbondy who was in this code recently (w/ bloodhound improvements)

@bsclifton
Copy link
Member

Is this a dupe of #9715?

@bsclifton bsclifton mentioned this issue Jul 12, 2017
Closed
@luixxiul
Copy link
Contributor Author

I don't think so as you get the error without enabling Sync.

@bsclifton
Copy link
Member

bsclifton commented Jul 12, 2017 •
edited
Loading

@luixxiul sync enabled not needed- see @diracdeltas comment:

I see the same bug on a fresh profile without sync enabled. If you click 'delete history entry', the history entry just gets added back at the bottom of the list.

@srirambv
Copy link
Collaborator

+2 from community https://community.brave.com/t/anyone-have-random-history-entries-that-still-come-up-even-with-all-history-deleted/4594/

@bsclifton bsclifton mentioned this issue Jul 12, 2017
Closed
@bsclifton
Copy link
Member

+1 from user @patrick99e99 (reported with #9884)

@cndouglas
Copy link

This seems separate but related to #8761/#9715.

@bbondy bbondy self-assigned this Jul 18, 2017
@luixxiul luixxiul modified the milestones: 0.22.x, 0.19.x (Beta Channel) Aug 7, 2017
@luixxiul luixxiul mentioned this issue Aug 11, 2017
Closed
@cndouglas
Copy link

+1 from me (#10421)

@cndouglas
Copy link

Regression of #5147

@bsclifton
Copy link
Member

@liunkae I don't think it's a regression- it was never fixed. #5147 was closed as stale

@hackobi
Copy link

hackobi commented Aug 21, 2017

I have the same problem but when I quit and relaunch the URL addresses are still there.

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bbondy Sep 5, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 5, 2017
@NejcZdovc
Removes history and bookmarks when they are removed from suggestions
d799cf1 
Resolves brave#9736

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 5, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 6, 2017
@NejcZdovc
Removes history and bookmarks when they are removed from suggestions
0fb3c60 
Resolves brave#9736

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 11, 2017
@NejcZdovc
Removes history and bookmarks when they are removed from suggestions
b1d4a73 
Resolves brave#9736

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.22.x Sep 11, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 11, 2017
@NejcZdovc
Removes history and bookmarks when they are removed from suggestions
e1d3cce 
Resolves brave#9736

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 12, 2017
@NejcZdovc
Removes history and bookmarks when they are removed from suggestions
6159ba0 
Resolves brave#9736

Auditors:

Test Plan:
bbondy added a commit that referenced this issue Sep 19, 2017
@bbondy
Merge pull request #10795 from NejcZdovc/feature/#9736-remove
9fa9989 
Removes history and bookmarks when they are removed from suggestions
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@luixxiul luixxiul mentioned this issue Nov 6, 2017
Closed
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/autocomplete feature/history feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
8 participants
@bbondy @luixxiul @bsclifton @NejcZdovc @srirambv @cndouglas @hackobi @LaurenWags