Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

History entries often cannot be deleted #8761

Closed
cndouglas opened this issue May 8, 2017 · 9 comments · Fixed by #10069
Closed

History entries often cannot be deleted #8761

cndouglas opened this issue May 8, 2017 · 9 comments · Fixed by #10069
Assignees
@diracdeltas
Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@cndouglas
Copy link

cndouglas commented May 8, 2017 •
edited by luixxiul
Loading

Test plan

#10069 (comment)

  • Did you search for similar issues before submitting this one?
    Yes.

  • Describe the issue you encountered:
    Often when using Delete History Entry, the history entry's timestamp is removed but the item is not deleted.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Found on macOS 10.12.x.

  • Brave Version (revision SHA):
    0.15.2 (af7ef42)

  • Steps to reproduce:

    1. Open a new Brave tab and visit github.com (make sure you are logged out).
    2. Visit each of the options at the top (Features, Business, Explore, and Pricing).
    3. Open about:history.
    4. Right-click one of the entries (e.g., Pricing) and click Delete History Entry.

  • Actual result:
    The history entry is moved to a section with no timestamp and is not deleted (see screenshot).

  • Expected result:
    The history entry should be completely deleted.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Not sure.

  • Is this an issue in the currently released version?
    Yes, 0.15.2.

  • Can this issue be consistently reproduced?
    Yes, with the steps above. It doesn't happen with every single time, though.

  • Extra QA steps:

    1. Open a new Brave tab and visit github.com (make sure you are logged out).
    2. Visit each of the options at the top (Features, Business, Explore, and Pricing).
    3. Open about:history.
    4. Right-click one of the entries (e.g., Pricing) and click Delete History Entry.
    5. Make sure the history item is deleted.

  • Screenshot if needed:
    image

  • Any related issues:
    None.
@eljuno
Copy link
Contributor

eljuno commented May 8, 2017

It happens to me, too, 0.15.2 (af7ef42).
I reported in community few days ago. https://community.brave.com/t/long-history-list-with-no-time-and-can-not-be-deleted/2693?u=eljuno

For now, I can delete it by clearing browsing data (Ctrl+Shift+Del). The history completly vanish. But when I manualy delete the entry, it repeat again.

Here's an additional record:
brave-history-bug

@cndouglas
Copy link
Author

@eljuno Thanks for the screen recording! Looks like it's happening on Windows too.

@eljuno
Copy link
Contributor

eljuno commented May 9, 2017

@liunkae ah, yes. I'm on Windows 8.1.

@ghost
Copy link

ghost commented May 18, 2017

I experience the same issue on Arch Linux, 0.15.2.

@cndouglas
Copy link
Author

Still a problem with 0.15.3xx. @bsclifton Any ideas?

@luixxiul luixxiul added this to the 1.2.0 milestone May 29, 2017
@cndouglas
Copy link
Author

Still happening with Brave 0.16.6 (51de9af).

@saskakol
Copy link

Still happening on Brave 0.17.13, Windows 10.

This was referenced Jul 13, 2017
Closed
Closed
@diracdeltas
Copy link
Member

bumping milestone to 0.19.x since #9715 was set to that

@diracdeltas diracdeltas modified the milestones: 0.19.x (Beta Channel), 1.2.0 Jul 13, 2017
@diracdeltas diracdeltas self-assigned this Jul 18, 2017
@diracdeltas
Copy link
Member

similar issue: if you right click to delete a history entry, it still shows up in the History menu

diracdeltas added a commit that referenced this issue Jul 19, 2017
@diracdeltas
Fix deleting history entry
ef785e4 
fix #8761

test plan:
1. open a new tab, go to some site
2. close the tab
3. open about:history. right-click to delete the site. it should disappear from the list
4. open the History menu. you should no longer see the site under 'Recently Closed'.
5. repeat above steps but opening/closing two tabs and selecting both of them to delete instead of only one
@diracdeltas diracdeltas mentioned this issue Jul 19, 2017
Merged
8 tasks
@srirambv srirambv mentioned this issue Jul 22, 2017
Closed
diracdeltas added a commit that referenced this issue Aug 3, 2017
@diracdeltas
Fix deleting history entry
67aef34 
fix #8761

test plan:
1. open a new tab, go to some site
2. close the tab
3. open about:history. right-click to delete the site. it should disappear from the list
4. open the History menu. you should no longer see the site under 'Recently Closed'.
5. repeat above steps but opening/closing two tabs and selecting both of them to delete instead of only one
@diracdeltas diracdeltas mentioned this issue Aug 7, 2017
Closed
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@diracdeltas @dfperry5
Fix deleting history entry
a732ed5 
fix brave#8761

test plan:
1. open a new tab, go to some site
2. close the tab
3. open about:history. right-click to delete the site. it should disappear from the list
4. open the History menu. you should no longer see the site under 'Recently Closed'.
5. repeat above steps but opening/closing two tabs and selecting both of them to delete instead of only one
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging a pull request may close this issue.

Fix deleting history entry brave/browser-laptop
7 participants
@diracdeltas @luixxiul @saskakol @srirambv @cndouglas @eljuno @LaurenWags