Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Close tabs to the left/right (tab page) #9789

Closed
NejcZdovc opened this issue Jun 30, 2017 · 2 comments
Closed

Close tabs to the left/right (tab page) #9789

NejcZdovc opened this issue Jun 30, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 30, 2017 •
edited by luixxiul
Loading

Test plan

#9790 (comment)

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    When you try to close all tabs except selected one and you have open tab pages, tabPage index is not updated. Found this bug when working on Blank tabs bar appears after increasing the number of tabs per tab set #7806

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    4cc1273

  • Steps to reproduce:

    1. open so many tabs that you have at least two tab pages
    2. right click on the last tab
    3. select "Close tabs to the left"

  • Actual result:
    image

  • Expected result:
    We should see our last tab

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 30, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 30, 2017
@NejcZdovc
Copy link
Contributor Author

This PR is blocked on #9678

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 30, 2017
@NejcZdovc
Fixes close tabs to the left/right
bcda03f 
when you have multiple tab pages

Resovles brave#9789

Auditors: @bsclifton

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 30, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 30, 2017
@NejcZdovc
Fixes close tabs to the left/right
ba0ca31 
when you have multiple tab pages

Resolves brave#9789

Auditors: @bsclifton

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 11, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 12, 2017
@NejcZdovc
Fixes close tabs to the left/right
84aee6e 
when you have multiple tab pages

Resolves brave#9789

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 13, 2017
@NejcZdovc
Fixes close tabs to the left/right
5d0301d 
when you have multiple tab pages

Resolves brave#9789

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 13, 2017
@NejcZdovc
Fixes close tabs to the left/right
0f509d4 
when you have multiple tab pages

Resolves brave#9789

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 14, 2017
@NejcZdovc
Fixes close tabs to the left/right
96d3a14 
when you have multiple tab pages

Resolves brave#9789

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 14, 2017
@NejcZdovc
Fixes close tabs to the left/right
a47b252 
when you have multiple tab pages

Resolves brave#9789

Auditors: @bsclifton

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 14, 2017
@NejcZdovc
Fixes close tabs to the left/right
4342b8c 
when you have multiple tab pages

Resolves brave#9789

Auditors: @bsclifton

Test Plan:
bbondy added a commit that referenced this issue Jul 14, 2017
@bbondy
Merge pull request #9790 from NejcZdovc/hotfix/#9789-tabpage
8b27a11 
Fixes close tabs to the left/right
bbondy added a commit that referenced this issue Jul 14, 2017
@bbondy
Merge pull request #9790 from NejcZdovc/hotfix/#9789-tabpage
8fce20a 
Fixes close tabs to the left/right
@bbondy bbondy modified the milestones: 0.19.x (Beta Channel), 0.18.x (Release Channel) Jul 14, 2017
@bbondy
Copy link
Member

bbondy commented Jul 14, 2017

Doesn't apply without redux to 0.18.x so we're moving this to 0.19.x

This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Sep 20, 2017
Closed
@LaurenWags LaurenWags mentioned this issue Sep 20, 2017
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @NejcZdovc @srirambv @LaurenWags