Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

use muon's IP address check instead of node's #10851

Merged
merged 1 commit into from Sep 7, 2017
Merged

use muon's IP address check instead of node's #10851

merged 1 commit into from Sep 7, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Sep 7, 2017

partial fix for #10825 (noscript allowing scripts when host is an ipv6 address)

Test Plan:

  1. npm run test -- --grep='can allow scripts when the url host is an ipv6 address' (the test is skipped on travis due to lack of ipv6 support)

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

partial fix for #10825 (noscript allowing scripts when host is an ipv6 address)

Test Plan:
1. npm run test -- --grep='can allow scripts when the url host is an ipv6 address' (the test is skipped on travis due to lack of ipv6 support)
@diracdeltas diracdeltas added this to the 0.21.x (Nightly Channel) milestone Sep 7, 2017
@diracdeltas diracdeltas self-assigned this Sep 7, 2017
Copy link
Member

@evq evq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diracdeltas diracdeltas merged commit ba55748 into master Sep 7, 2017
@diracdeltas diracdeltas deleted the fix/isIP branch September 7, 2017 23:24
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants