Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix URL bar #13774

Merged
merged 1 commit into from
May 3, 2018
Merged

Fix URL bar #13774

merged 1 commit into from
May 3, 2018

Conversation

aushakou
Copy link

@aushakou aushakou commented Apr 9, 2018

Set min-width of URL bar to 30px, so URL bar does not shrink too much and URL bar elements are not layered on each other when window width is reduced.

Fix #13773

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Go to Preferences -> Advanced
  2. Set "Toolbar and UI elements scale" to "Larger" or "Supersize"
  3. Reduce the width of the window
  4. URL bar elements are not layered on each other

Before:

brave_1

After:

brave-fixed-1
brave-fixed-2

@aushakou
Set min-width of URL bar to 30px
5b6f93d 
Set min-width of URL bar to 30px, so URL bar does not shrink
too much and URL bar elements are not layered on each other
when window width is reduced.

Fix brave#13773
@NejcZdovc NejcZdovc added the polish Nice to have — usually related to front-end/visual tasks. label Apr 9, 2018
@bsclifton bsclifton added this to the Completed work milestone May 1, 2018
@bsclifton bsclifton self-requested a review May 1, 2018 00:13
cezaraugusto
cezaraugusto approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aushakou congrats on your first contribution to browser-laptop! Thanks for making this fix. LGTM 👌

@cezaraugusto cezaraugusto merged commit 7c6d70a into brave:master May 3, 2018
@bsclifton bsclifton modified the milestones: Completed work, 0.24.x (Nightly Channel) May 3, 2018
@aushakou aushakou mentioned this pull request May 3, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@aushakou aushakou

Labels
polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.24.x-legacy
Development

Successfully merging this pull request may close these issues.

URL bar elements are layered on each other when window width is reduced
4 participants
@aushakou @cezaraugusto @bsclifton @NejcZdovc