This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Eth-wallet #14727
Closed
Eth-wallet #14727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge when a wallet recovery is successful, and when it is cancelled or closed out of.
* Release notes for 0.22.22 * Update CHANGELOG.md
Fixes twitch event logging
Fixes invalid url error
Removes ledgerPinPercentage setting
Opens add funds overlay when clicking on it in the notification
Updates recovery dialog text and buttons
…ffer-window Fix automated tests post-0.22.x
Resolves brave#13751 Auditors: Test Plan:
Send hostname option to webtorrent to mitigate DNS rebinding
…cused Fix brave#13859 Fix brave#13860 Fix brave#13865 Makes sure tabs are created in a shown window, or creates a new window, that the window is focused, and if the shown window is minimized, then that window is restored. Fixes for the following scenarios...: - There are no windows open - There are only minimized windows open ...For the following actions: - Brave is default browser and link clicked in another application - macOS dock icon is clicked - 'Brave' menu actions such as 'New Tab' or 'About Brave' Test plan: Browser must be set as default. If testing from source, the best way is to create a build `CHANNEL=dev npm run build-package`, run that, and set it as default. - Click URL link in external application - Ensure that tab opens in an active window, and the window is focused with the following scenarios: - 1 window open - 2+ windows open - 0 windows open - 1 minimized window open - 1 minimized window open and 1 non-minimized window open - Application exited - macOS: click dock icon, ensure window is focused or created: - 1 window open - 2+ windows open - 0 windows open - 1 minimized window open - 1 minimized window open and 1 non-minimized Even though the reported issues were macOS only, this test plan should be carried out on other platforms to ensure no regressions.
Fixes null case for fields
…t entry Reverting old solution
…-window Ensure tabs are not created in hidden window and correct window is focused
Resolves brave#13721 Auditors: Test Plan:
Fixes wallet recovery dialogue re-appearing on relaunch after a successful recovery.
Resolves brave#13227 Auditors: Test Plan:
Fixes sortTable default sort
Handle auto-update case properly for quarantine
WIP -- unit test Moved url stripping logic to urlutil. Implemented unit tests Removed logging debug statements shortenUrlToDomainTLD now more utility than ledger based. corrected lint corrected types and checks merge lint wip -- refactor shortenUrlToDomainTLD wip -- fixup unit tests wip -- moved logic to own function to get publisher key Removed file (wrong branch) Updated url shortener and moved getter to separate getter. linting Corrected URL parsing logic and tests Update verified publisher method and updated tests corrected parsing for publisher keys check for null parsedUrl.hostname Renamed function to reflect params
Some verified publishers no longer remove green tick at sublevels - Fixes issue brave#10484
Auditors: Test Plan:
* muon unit test runner cleanup * muon unit test runner able to do async * muon unit test runner add before/affter Auditors: Test Plan:
Fixes width of the balance input
Fixes disabled create wallet button
Don't break up as URL for autocomplete if location bar text isn't a URL
…testing of STAGING ad-block definitions Fixes brave#13909 Auditors: @bbondy
Resolves brave#10767 Auditors: Test Plan:
Fixes disabled torrent viewer torrent download
Resolves brave#14141 Auditors: Test Plan:
… place Fixes brave#14204 Auditors: @diracdeltas
Adds nsp to travis checks
Add a session migration for uphold fingerprinting
remove unneccessary console warning
Resolves brave#10767 Auditors: Test Plan:
Fixes WebTorrent not being enabled
Referrer page loads quickly and code was previously calling createTabRequested well before window was ready. This would cause the partner page to load first (before about:welcome). Fixes brave#14220 Auditors: @NejcZdovc
Resolves brave#14190 Auditors: Test Plan:
Only call createTabRequested if window is ready
fix brave#14231 (workaround) Test Plan: 1. go to a secure URL ending in a hash such as https://github.com/brave/browser-laptop/wiki/Fingerprinting-Protection-Mode#technical-details 2. toggle shields or click 'reload' in the shields menu 3. the page should appear as still secure instead of changing to insecure
set reloadMatchingUrl to true for URLs ending in a hash
Adds batch voting
Release notes for 0.22.x Release 4
…e4-Fix Fixed a mistake in the 0.22.x Release 4 notes
Resolves brave#14188 Auditors: Test Plan:
…tcha Adds captcha to UGP flow
Resolves brave#14229 Auditors: Test Plan:
…akdown Adds balance breakdown
Resolves brave#14245 Auditors: Test Plan:
Resolves brave#8537 Auditors: Test Plan:
Adds clear/delete payments options
…lude Removes site settings for delete sites
|
Reopened in #14734 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #13177 + updates
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests