Issue 15: Set the fallback URL for google extensions/components to componentupdater.brave.com. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
componentupdater.brave.com. CRLSets which is maintained by google will be enabled by default in Brave to handle revoked certificates. To prevent any connections to google servers by default we are setting the fallback URL for google extensions and components to componentupdater.brave.com which removes any user identifiable information before forwarding the requests to the google component update server. More details here: brave/brave-browser#518 auditors: @bbondy, @bsclifton, @diracdeltas
jumde
force-pushed
the
update_default_url
branch
from
fece010
to
17b01e4
Compare
bbondy
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15
Description
CRLSets which is maintained by google will be enabled by default in Brave to handle revoked certificates on all platforms. To prevent any connections to google servers by default we are setting the fallback URL for google extensions and components to componentupdater.brave.com which removes any user identifiable information before forwarding the requests to the google component update server.
More details here: brave/brave-browser#518
auditors: @bbondy, @bsclifton, @diracdeltas
CRLSets PR: brave/brave-core#1581
Feel free to DM if you need more info.
Test Plan
Before CRLSets
MacOS:
Linux:
Windows:
After CRLSets
MacOS:
Linux:
Windows: