Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

C67: spellcheck not working on Linux/Win #597

Closed
ltilve opened this issue May 18, 2018 · 6 comments
Closed

C67: spellcheck not working on Linux/Win #597

ltilve opened this issue May 18, 2018 · 6 comments
Assignees
@darkdh

Comments

@ltilve
Copy link
Contributor

ltilve commented May 18, 2018

On the current status of the C67 PR #596, spellcheck seems that is not working.
@ltilve ltilve changed the title C67: spellcheck not working C67: spellcheck not working on Linux May 22, 2018
@ltilve
Copy link
Contributor Author

ltilve commented May 22, 2018

The issue is happening on Linux. On Mac Spellcheck seems to be working correctly.

@ltilve ltilve changed the title C67: spellcheck not working on Linux C67: spellcheck not working on Linux/Win May 24, 2018
@ltilve
Copy link
Contributor Author

ltilve commented May 24, 2018

It's also failing on Win. Seems that is just working fine with Mac use_browser_spellchecker

@darkdh darkdh self-assigned this May 26, 2018
@darkdh
Copy link
Member

darkdh commented May 29, 2018

it does work for me on Linux. What issue did you encounter?

@ltilve
Copy link
Contributor Author

ltilve commented May 30, 2018

It seems I can still reproduce it on a fresh build and on with the brave-beta 67.0.3396.48. I'm not seeing the red underline on textareas, even though it is enabled.
typo
spell1

@darkdh
Copy link
Member

darkdh commented May 30, 2018

this can only be reproducible on our PACKAGED build(npm run build-package), not from blb or browser-laptop launch (npm start)
@bsclifton ^^^

darkdh added a commit that referenced this issue May 31, 2018
@darkdh
Do not block hunspell dictionary downloading request
59e9a42 
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433
changes to SimpleURLLoader

fix #597

Auditors: @bridiver, @ltilve
@darkdh darkdh mentioned this issue May 31, 2018
Closed
darkdh added a commit to brave/browser-laptop that referenced this issue Jun 1, 2018
@darkdh
Early return but don't cancel request when firstPartyURL is empty
f3e97cd 
because the request sent from muon in order to download hunspell
dictionaries has empty firstPartyURL since this change
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433

fix brave/muon#597

Auditors: @bridiver, @ltilve
@darkdh
Copy link
Member

darkdh commented Jun 1, 2018

fixed by brave/browser-laptop@f3e97cd

@darkdh darkdh closed this as completed Jun 1, 2018
bsclifton pushed a commit to brave/browser-laptop that referenced this issue Jun 1, 2018
@darkdh @bsclifton
Early return but don't cancel request when firstPartyURL is empty
0e868ef 
because the request sent from muon in order to download hunspell
dictionaries has empty firstPartyURL since this change
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433

fix brave/muon#597

Auditors: @bridiver, @ltilve
bsclifton pushed a commit to brave/browser-laptop that referenced this issue Jun 1, 2018
@darkdh @bsclifton
Early return but don't cancel request when firstPartyURL is empty
a77549d 
because the request sent from muon in order to download hunspell
dictionaries has empty firstPartyURL since this change
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433

fix brave/muon#597

Auditors: @bridiver, @ltilve
bsclifton pushed a commit to brave/browser-laptop that referenced this issue Jun 4, 2018
@darkdh @bsclifton
Early return but don't cancel request when firstPartyURL is empty
0561a09 
because the request sent from muon in order to download hunspell
dictionaries has empty firstPartyURL since this change
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433

fix brave/muon#597

Auditors: @bridiver, @ltilve
bsclifton pushed a commit to brave/browser-laptop that referenced this issue Jun 8, 2018
@darkdh @bsclifton
Early return but don't cancel request when firstPartyURL is empty
3986e78 
because the request sent from muon in order to download hunspell
dictionaries has empty firstPartyURL since this change
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433

fix brave/muon#597

Auditors: @bridiver, @ltilve
bsclifton pushed a commit to brave/browser-laptop that referenced this issue Jun 12, 2018
@darkdh @bsclifton
Early return but don't cancel request when firstPartyURL is empty
f63a7e5 
because the request sent from muon in order to download hunspell
dictionaries has empty firstPartyURL since this change
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433

fix brave/muon#597

Auditors: @bridiver, @ltilve
bsclifton pushed a commit to brave/browser-laptop that referenced this issue Jun 12, 2018
@darkdh @bsclifton
Early return but don't cancel request when firstPartyURL is empty
48b44ff 
because the request sent from muon in order to download hunspell
dictionaries has empty firstPartyURL since this change
https://chromium.googlesource.com/chromium/src/+/9dbbf9f17b4804cb27b7ac34ee540f9eddd61433

fix brave/muon#597

Auditors: @bridiver, @ltilve
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ltilve @darkdh