Skip to content

Commit

Permalink
Fix test on LineMerger broken-ness
Browse files Browse the repository at this point in the history
If the same line appears twice from different input, it's totally fine.
For example, `"ab.wikipedia,1,1` appears in the pageviews files for multiple
weeks, and of course it's fine (and expected) that LineMerger passes them on.
  • Loading branch information
brawer committed May 17, 2024
1 parent 60d05f9 commit bd246b2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/qrank-builder/itemsignals.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func buildItemSignals(ctx context.Context, pageviews []string, sites *map[string
}
numLines += 1
line := merg.Line()
if lastLine >= line {
if lastLine > line {
numOrderErrors += 1
if numOrderErrors < 10 {
logger.Printf(`LineMerger broken: "%s" after "%s"`, line, lastLine)
Expand Down

0 comments on commit bd246b2

Please sign in to comment.