Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: generate lib and lock jane-php/open-api-runtime to 7.5 #57

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

remarkablemark
Copy link
Member

@remarkablemark remarkablemark commented Mar 12, 2024

What is the motivation for this pull request?

Generate Braze lib so that normalizers are compatible with the contracts from the latest version of Symfony serializer and lock jane-php/open-api-runtime to 7.5

Fixes #55

What is the current behavior?

PHP Fatal error:  Declaration of Braze\Runtime\Normalizer\ReferenceNormalizer::supportsNormalization($data, $format = null): bool must be compatible with Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool in /home/runner/work/braze-php/braze-php/lib/Runtime/Normalizer/ReferenceNormalizer.php on line 28

   Whoops\Exception\ErrorException 

  Declaration of Braze\Runtime\Normalizer\ReferenceNormalizer::supportsNormalization($data, $format = null): bool must be compatible with Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool

PHP >=7.2

What is the new behavior?

Regenerate Braze lib and lock jane-php/open-api-runtime to 7.5

BREAKING CHANGE: PHP >=8.0

Checklist:

@remarkablemark remarkablemark added the bug Something isn't working label Mar 12, 2024
@remarkablemark remarkablemark self-assigned this Mar 12, 2024
@remarkablemark remarkablemark force-pushed the fix/lib branch 10 times, most recently from beb1eb9 to 8790504 Compare March 12, 2024 22:44
Fixes #55

BREAKING CHANGE: drop PHP version 7 and require PHP >=8.0
@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Mar 12, 2024
@remarkablemark remarkablemark changed the title fix(lib): generate braze code fix!: generate lib and lock jane-php/open-api-runtime to 7.5 Mar 12, 2024
@remarkablemark remarkablemark changed the title fix!: generate lib and lock jane-php/open-api-runtime to 7.5 fix!: generate lib and lock jane-php/open-api-runtime to 7.5 Mar 12, 2024
@remarkablemark remarkablemark merged commit fea73ef into master Mar 12, 2024
13 checks passed
@remarkablemark remarkablemark deleted the fix/lib branch March 12, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony Serializer Incompatability
1 participant