Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony Serializer Incompatability #55

Closed
damiantw opened this issue Mar 12, 2024 · 5 comments · Fixed by #57 or #58
Closed

Symfony Serializer Incompatability #55

damiantw opened this issue Mar 12, 2024 · 5 comments · Fixed by #57 or #58
Assignees
@remarkablemark
Labels
bug Something isn't working

Comments

@damiantw
Copy link

Normalizers are incompatible with the contracts from the latest version of Symfony serializer.

Fatal error: Declaration of Braze\Normalizer\JaneObjectNormalizer::denormalize($data, $class, $format = null, array $context = []) must be compatible with Symfony\Component\Serializer\Normalizer\DenormalizerInterface::denormalize(mixed $data, string $type, ?string $format = null, array $context = []): mixed in /Users/damian/Desktop/braze-php/lib/Normalizer/JaneObjectNormalizer.php on line 52

To reproduce, clone this repository, then run:

composer install && ./vendor/bin/pest
@damiantw damiantw added the bug Something isn't working label Mar 12, 2024
@remarkablemark
Copy link
Member

@damiantw what version of PHP are you using?

@damiantw
Copy link
Author

@remarkablemark 8.3

@remarkablemark
Copy link
Member

@damiantw I was able to reproduce the error, I will work on a fix

remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate braze code
d50a643 
Fixes #55

Release-As: 1.4.1
@remarkablemark remarkablemark mentioned this issue Mar 12, 2024
Merged
3 tasks
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate code from braze specification
da304af 
Fixes #55

BREAKING CHANGE: drop support for PHP version 7
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate code from braze specification
3aff327 
Fixes #55

BREAKING CHANGE: drop support for PHP version 7
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate code from braze specification
f053965 
Fixes #55

BREAKING CHANGE: drop support for PHP version 7
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate code from braze specification
99a7d4d 
Fixes #55

BREAKING CHANGE: drop support for PHP version 7
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate code from braze specification
ac3423a 
Fixes #55

BREAKING CHANGE: require PHP >=8.2
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate code from braze specification
86b3326 
Fixes #55

BREAKING CHANGE: require PHP >=8.2
@remarkablemark
Copy link
Member

This seems to be related to janephp/janephp#785

remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate code from braze specification
39b5c48 
Fixes #55

BREAKING CHANGE: require PHP >=8.2
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate lib and lock jane-php/open-api-runtime to 7.5
393ab56 
Fixes #55
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate lib and lock jane-php/open-api-runtime to 7.5
beb1eb9 
Fixes #55
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate lib and lock jane-php/open-api-runtime to 7.5
8790504 
Fixes #55

BREAKING CHANGE: drop PHP version 7 and require PHP >=8.0
remarkablemark added a commit that referenced this issue Mar 12, 2024
@remarkablemark
fix(lib): generate lib and lock jane-php/open-api-runtime to 7.5
b48a0e2 
Fixes #55

BREAKING CHANGE: drop PHP version 7 and require PHP >=8.0
@github-actions github-actions bot mentioned this issue Mar 12, 2024
Merged
@remarkablemark
Copy link
Member

@damiantw released:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remarkablemark remarkablemark

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@remarkablemark @damiantw