Legacy reads should also check #write_retryable? on retry

braze-inc · Jun 13, 2024 · 4bb1d09 · 4bb1d09
1 parent 860b4ff
commit 4bb1d09
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/mongo/retryable/read_worker.rb b/lib/mongo/retryable/read_worker.rb
@@ -218,7 +218,10 @@ def legacy_read_with_retry(session, server_selector, &block)
 
         if is_retryable_exception?(e)
           raise e if attempt > client.max_read_retries || session&.in_transaction?
-        elsif e.retryable? && !session&.in_transaction?
+        # some new retryable errors only include WriteRetryable
+        elsif e.respond_to?(:write_retryable?) && !e.write_retryable? && !session&.in_transaction?
+          raise e if attempt > client.max_read_retries
+        elsif e.respond_to?(:retryable?) && e.retryable? && !session&.in_transaction?
           raise e if attempt > client.max_read_retries
         else
           raise e