Better handling of PoolClearedError during legacy read #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelim41
reviewed
Jun 13, 2024
| @@ -218,7 +218,7 @@ def legacy_read_with_retry(session, server_selector, &block) | |||
|
|
|||
| if is_retryable_exception?(e) | |||
| raise e if attempt > client.max_read_retries || session&.in_transaction? | |||
| elsif e.retryable? && !session&.in_transaction? | |||
| elsif e.respond_to?(:retryable?) && e.retryable? && !session&.in_transaction? | |||
There was a problem hiding this comment.
should we match the new method modern_read_with_retry way of handling these new errors instead? e.g. handle write_retryable errors here
There was a problem hiding this comment.
I tried that initially but saw some legit test failures so I think that might be changing the behavior of this too much
joelim41
reviewed
Jun 13, 2024
| @@ -58,7 +58,8 @@ def retryable_exceptions | |||
| Error::ConnectionPerished, | |||
| Error::ServerNotUsable, | |||
| Error::SocketError, | |||
| Error::SocketTimeoutError | |||
| Error::SocketTimeoutError, | |||
| Error::PoolClearedError, | |||
There was a problem hiding this comment.
might want to add the other PoolErrors here
|
I don't feel confident that any of us know this code well enough to be patching this in a rush. I think we ought to open a PR upstream and to get more perspective from the maintainers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/braze-inc/mongo-ruby-driver/blob/deployed-in-platform/spec/integration/retryable_reads_errors_spec.rb#L76 it looks like
PoolClearedErrorcan be retried on reads.Also updates
#legacy_read_with_retry?to check whether the error responds to#retryable?before attempting to call it.