Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

Remaining workarounds for Mongoid 7.2: remove atomic_selector caching plus post persist callback workaround #1

Conversation

dalton-braze
Copy link

No description provided.

Comment on lines 33 to 34
@atomic_selector =
(embedded? ? embedded_atomic_selector : root_atomic_selector)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assignment wouldn't even be necessary if the (single) other place that references @atomic_selector were also removed, and then this could become

Suggested change
@atomic_selector =
(embedded? ? embedded_atomic_selector : root_atomic_selector)
embedded? ? embedded_atomic_selector : root_atomic_selector

but I don't think it's a big deal

@dalton-braze dalton-braze merged commit d43bdd8 into 7.2.x-custom-fork Apr 16, 2021
@dalton-braze dalton-braze deleted the remove-atomic-selector-caching-plus-after-save-workaround branch April 16, 2021 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants