This repository has been archived by the owner on Jul 26, 2020. It is now read-only.
Import using video URL #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmickey
added
enhancement
…-url * origin/master: Add API key option for use in CI (#14)
dirkkelly
approved these changes
May 17, 2019
| } | ||
|
|
||
| if url != "" { | ||
| re := regexp.MustCompile(`(?:v|embed|watch\?v)(?:=|/)([^"&?/=%]{11})`) |
There was a problem hiding this comment.
Another valid format is https://youtu.be/rURhJr0cDnk and it's been used in a few submissions so far.
I'd be happy for us to have limitations on acceptable formats for simplicity sake, eg:
- https://www.youtu.be/rURhJr0cDnk
- https://www.youtube.com/embed/rURhJr0cDnk
- https://www.youtube.com/watch?v=xspEtjnSfQA
Perhaps the regex is something along the lines of v=XXX or final slash and everything after.
Say I tried https://youtu.be/rURhJr0cDnk?rofl=lmao I would be happy for the parser to fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18.