This repository has been archived by the owner on Jul 26, 2020. It is now read-only.
Linting, Pre-Commit, and Release #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmickey
added
maintenance
xp/developer
dirkkelly
previously approved these changes
May 17, 2019
There was a problem hiding this comment.
This is absolutely amazing @jaymickey you have done an amazing job getting this repo into the state it is, thank you so much!
I confirmed
- Linting
- go mod tidy
I didn't try
- Releasing
I have a few comments but they're all around README that don't need to hold this up.
There is that question though about the go mod tidy differences #21 I think though it's just version differences?
Co-Authored-By: Dirk Kelly <github@dirkkelly.com>
Co-Authored-By: Dirk Kelly <github@dirkkelly.com>
dirkkelly
previously approved these changes
May 17, 2019
dirkkelly
approved these changes
May 17, 2019
This was referenced May 24, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We write Go at work and recently started using
golangci-lintand finding it super handy!Fixed some errors so that everything passes, and updated the circle config. Also added a
.pre-commit-config.yamlfor use with pre-commit.I have also configured GoReleaser, which will allow us to create tags that will automatically deploy binaries to GitHub Projects as per #10.