Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow resiliency with accepted extensions #229

Merged
merged 1 commit into from Nov 21, 2023

Conversation

mikevalstar
Copy link
Contributor

Upgrade resiliency with file extensions on jobs

Currently if you specify a file extension that does not start with a . it will think a job like defaults is a typescript file.

Alternatively I can add a check similar to the default extension that already exists, but i thought this would be better?

Happy to have some feedback as needed.

Thanks for creating such a good tool

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@tsconfig/node20 20.1.2 None +0 2.5 kB typescript-deploys
@types/node 20.8.3 None +0 3.92 MB types

@mikevalstar
Copy link
Contributor Author

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@tsconfig/node20 20.1.2 None +0 2.5 kB typescript-deploys
@types/node 20.8.3 None +0 3.92 MB types

Note: this is only for the example I added, no changes to the main library

@titanism titanism merged commit 2e2afd1 into breejs:master Nov 21, 2023
2 checks passed
@titanism
Copy link
Contributor

apologies for delay, we've been working hard on https://forwardemail.net 🚀

v9.2.0 released to npm just now https://github.com/breejs/bree/releases/tag/v9.2.0

fyi - we did a minor bump since don't use nor support TypeScript (we dislike it with with a passion) but we tried to bump package type stuff around to make things work (tests were broken in ci). playing it safe by doing this as a minor bump.

thank you for your contributions @mikevalstar 🙏 🙇

p.s. check out our encrypted sqlite IMAP support just released in November.

@titanism
Copy link
Contributor

had to deprecate v9.2.0 due to #232

please use v9.2.1+ instead

glad we did the minor bump.

https://github.com/breejs/bree/releases/tag/v9.2.1

climba03003 added a commit to climba03003/bree that referenced this pull request Nov 21, 2023
@climba03003 climba03003 mentioned this pull request Nov 21, 2023
6 tasks
titanism added a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants