Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] cannot extends types #232

Closed
3 tasks done
climba03003 opened this issue Nov 21, 2023 · 5 comments
Closed
3 tasks done

[fix] cannot extends types #232

climba03003 opened this issue Nov 21, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@climba03003
Copy link
Contributor

Describe the bug

Node.js version: *

OS version: *

Description: 8482d16 is trying to fix the lint error, but it produce a breaking change to the TypeScript user. It changes all interface to type which are not allow to do declaration merging.

Actual behavior

Not able to do so.

Expected behavior

Allow declaration merging.

Code to reproduce

TypeScript allow declaration merging to extends the types of packages.
It allow the ability to create plugins and extends it's original types.
For example, I would like to add a property foo to the job.

declare module 'bree' {
  interface Job {
    foo: string
  }
}

Checklist

  • I have searched through GitHub issues for similar issues.
  • I have completely read through the README and documentation.
  • I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.
@climba03003 climba03003 added the bug Something isn't working label Nov 21, 2023
@climba03003 climba03003 changed the title [fix] cannot extends types due to https://github.com/breejs/bree/commit/8482d166d0ed2c57e9eed21dd49fefd8370ce90c [fix] cannot extends types Nov 21, 2023
@climba03003
Copy link
Contributor Author

cc @titanism

@titanism
Copy link
Contributor

just deprecated v9.2.0, sec

@titanism
Copy link
Contributor

ok, fixed, v9.2.1 released

https://github.com/breejs/bree/releases/tag/v9.2.1

@climba03003
Copy link
Contributor Author

Thanks for quick response.

@titanism
Copy link
Contributor

ofc @climba03003 – we use bree at https://forwardemail.net btw 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants