Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cln lspd #23

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Cln lspd #23

merged 2 commits into from
Nov 24, 2022

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Nov 18, 2022

Implement the CLN lspd into the new frame introduced in PR #22. This PR is pointed to the prepare-for-cln branch, not master.

Next steps are

  • re-adding the small set of integration tests to test whether this frame actually works
  • adding more integration tests for both cln and lnd

roeierez
roeierez approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JssDWt JssDWt merged commit c577956 into prepare-for-cln Nov 24, 2022
@JssDWt JssDWt deleted the cln-lspd branch November 24, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaslama yaslama yaslama approved these changes

@roeierez roeierez roeierez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JssDWt @yaslama @roeierez