unconfirmed utxo from internal wallet #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLN does not look at the mempool, so the integration test that tests whether channels can be opened using unconfirmed utxos didn't work for CLN.
I've changed the test so that the unconfirmed output is sent from the internal wallet instead of the miner. This way CLN does track the unconfirmed output and is able to use it for opening channels when minConfs=0.
This means using minConfs=0 does also work for CLN, but only when there are unconfirmed utxos available that are tracked by the internal wallet.
Completes #68