Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct version of glightning [issue #90] #96

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

lnd3v
Copy link

@lnd3v lnd3v commented Jul 13, 2023

  • This is a "share early and often" PR
  • It includes the automated tests, the change to the channel acceptor etc. these commits will get dropped for the final PR
  • Fixups to this PR will run TestLspd/CLN-lspd:_testOpenZeroConfSingleHtlc
  • One approach to not include the actions like this is to store them in breez/lntest under an 'actions' directory and pull them in.
  • Currently the main issue seems to be when the LSP opens a zero conf channel, it's in awaiting lockin state, rather than normald (please advise)
  • currently go.mod uses lnd3v/lntest but will switch to breez/lntest once that PR is merged in

https://github.com/lnd3v/lspd/actions/runs/5538109074/jobs/10107704740

Copy link
Collaborator

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we do need to apply our changes on top of elementsproject/glightning too.

  • Aliases
  • mindepth
  • reserve

This is the branch we're using for glightning currently: https://github.com/breez/glightning/tree/lspd-working-branch

go.mod Outdated Show resolved Hide resolved
cln/cln_client.go Outdated Show resolved Hide resolved
cln/cln_client.go Show resolved Hide resolved
cln/cln_client.go Show resolved Hide resolved
cln/cln_client.go Outdated Show resolved Hide resolved
@lnd3v
Copy link
Author

lnd3v commented Jul 13, 2023

Updated. Forked glightning, and pointing to fork. CLN test are now failing non-deterministically. Need to check if output index is being picked up properly, same for channel aliases.

@lnd3v
Copy link
Author

lnd3v commented Jul 13, 2023

All tests pass, two tests disabled.

https://github.com/lnd3v/lspd/actions/runs/5542391138

          SKIP_TESTOFFLINENOTIFZEROCONF=1 \
          SKIP_TESTFAILUREBOBOFFLINE=1 \

@lnd3v lnd3v force-pushed the glightning branch 4 times, most recently from d04600a to d89d77a Compare July 13, 2023 23:20
@JssDWt JssDWt force-pushed the glightning branch 2 times, most recently from 6aea573 to 8916818 Compare July 28, 2023 14:21
- Replace niftynei/glightning with elementsproject/glightning
- Use latest version of breez/lntest
@JssDWt JssDWt force-pushed the glightning branch 2 times, most recently from 0bbfd04 to 349ef98 Compare July 28, 2023 15:15
@JssDWt JssDWt merged commit 349ef98 into breez:master Jul 28, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants