Re-enable opcache.validate_timestamps #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change disables a non-standard optimization that was applied automatically by Bref. The main reason it was applied was that the code source is read-only on Lambda. However, that is not 100% true: code written to `/tmp` is read/write (for example when using `/tmp` as a cache directory, or for a compiled container, etc.). The `opcache.validate_timestamps=0` would cause bugs very hard to debug. Additionally, switching to `opcache.validate_timestamps=1` will allow code in development to be reloaded when changed without having to restart containers. This could cause a very small performance regression, but I consider that less important than fixing an actual bug. Users are welcome to re-enable that option in `php.ini`: ``` opcache.validate_timestamps=0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables a non-standard optimization that was applied automatically by Bref. The main reason it was applied was that the code source is read-only on Lambda.
However, that is not 100% true: code written to
/tmpis read/write (for example when using/tmpas a cache directory, or for a compiled container, etc.). Theopcache.validate_timestamps=0would cause bugs very hard to debug.Additionally, switching to
opcache.validate_timestamps=1will allow code in development to be reloaded when changed without having to restart containers.This could cause a very small performance regression, but I consider that less important than fixing an actual bug.
Users are welcome to re-enable that option in
php.ini: