add command to deploy in local and give parameters to serverless invoke #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
May 25, 2018
bref
Outdated
| foreach ($buildHooks as $buildHook) { | ||
| $io->writeln('Running ' . $buildHook); | ||
| $commandRunner->run('cd .bref/output && ' . $buildHook); | ||
| } |
There was a problem hiding this comment.
Thanks for the PR! If I'm not mistaken everything above this is duplicated from the deploy command? Maybe that code could be shared instead, moved to a class maybe? I'm thinking a generate() method in a src/Console/Deployer class for example.
There was a problem hiding this comment.
Yes you are right, it's a big duplication of deploy command. I would just propose you this feature in a simple way to saw if it's was a good idea.
I will refacto this and send you a new commit
mnapoli
reviewed
May 25, 2018
bref
Outdated
| @@ -52,6 +52,104 @@ $app->command('init', function (SymfonyStyle $io) { | |||
| ]); | |||
| }); | |||
|
|
|||
| $app->command('local [data]', function(?string $data, SymfonyStyle $io) { | |||
There was a problem hiding this comment.
Could you add a comment above this line? Something that says something like "Runs the lambda locally".
brefphp-bot
pushed a commit
to brefphp-bot/bref
that referenced
this pull request
Nov 18, 2021
fix file path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to deploy on local machine with serveless I need to give some paremeters to the invoke function