Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a layer for the opentelemetry php extension #501

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

layers/opentelemetry/Dockerfile Outdated Show resolved Hide resolved
@GrahamCampbell
Copy link
Contributor

How large is the generated layer, btw?

layers/opentelemetry/Dockerfile Outdated Show resolved Hide resolved
@iokiwi
Copy link
Contributor Author

iokiwi commented Nov 20, 2023

How large is the generated layer, btw?

-rw-r--r-- 1 simon simon 11K Nov 19 14:00 layer-opentelemetry-php-80.zip
-rw-r--r-- 1 simon simon 11K Nov 19 14:00 layer-opentelemetry-php-81.zip
-rw-r--r-- 1 simon simon 11K Nov 19 14:00 layer-opentelemetry-php-82.zip

layers/opentelemetry/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still keep the make flags, but this is fast to build in any case, so it won't make a lot of difference (if implemented correctly for grpc, it actually does make a big difference there).

This reverts commit 7258cc9.
@iokiwi
Copy link
Contributor Author

iokiwi commented Nov 21, 2023

Aight restored. Yeah I should have checked what they do. Probably wont make a big practical differences as opentelemetry is quick but might as well have them.

Thanks!

@iokiwi
Copy link
Contributor Author

iokiwi commented Nov 22, 2023

Hey sorry I added the extension to the readme as well. I don't have merge rights so I'm not sure what the next steps after reviewer approval are.

@mnapoli mnapoli merged commit 66f8541 into brefphp:master Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants