Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot parse "serverless.yml": unknown tag !<!node_modules/**> #57

Closed
HELMAB opened this issue Nov 1, 2021 · 2 comments · Fixed by #58
Closed

Cannot parse "serverless.yml": unknown tag !<!node_modules/**> #57

HELMAB opened this issue Nov 1, 2021 · 2 comments · Fixed by #58

Comments

@HELMAB
Copy link

HELMAB commented Nov 1, 2021

I'm running Laravel 8, Bref 1.3 and Laravel-Bridge 1.1

When I run serverless deploy

I got this error:

Cannot parse "serverless.yml": unknown tag !<!node_modules/**> in "/Users/aws/Desktop/laravel-aws-lambda/serverless.yml" (16:9)

13 | # Directories to exclude from deplo ...
14 | patterns:
15 | - !node_modules/**
16 | - !public/storage
--------------^
17 | - !resources/assets/**
18 | - !storage/**

Does anybody face this problem?

@mnapoli
Copy link
Member

mnapoli commented Nov 1, 2021

Following #56 @t-richard I wonder if we need to quote !node_modules/**?

t-richard added a commit to t-richard/laravel-bridge that referenced this issue Nov 1, 2021
Tested locally and it fixes brefphp#57
@t-richard
Copy link
Member

It's indeed linked to this change 🙄

I've opened #58 to fix it.

In the meantime, @HELMAB you can change your serverless.yml accordingly 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants