Rework SQS documentation to be clearer #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following brefphp#49. The docs weren't clear about permissions which lead to the issue. Here I advise to disable auto_setup and set the appropriate permissions. I also took this as an opportunity to suggest using Lift.
mnapoli
reviewed
Jul 4, 2021
README.md
Outdated
| You can create the Queue yourself in the Console, write custom Cloudformation | ||
| or use [Lift's Queue construct](https://github.com/getlift/lift/blob/master/docs/queue.md) that will handle that for you. | ||
|
|
||
| Here is a simple example with Lift, check out the [full documentation](https://github.com/getlift/lift/blob/master/docs/queue.md) for more details. |
There was a problem hiding this comment.
Maybe mention that the Lift plugin needs to be installed? (with a link to the README?)
Co-authored-by: Matthieu Napoli <matthieu@mnapoli.fr>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #49.
The docs weren't clear about permissions which lead to the issue.
Here I advise to disable
auto_setupand set the appropriate permissions. I also took this as an opportunity to suggest using Lift.Not sure we should keep examples both with and without Lift or just point to external docs when not using Lift.
Let me know what you think.