New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host header is a requirement for V4 request signing #264

Merged
merged 3 commits into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@ixmatus
Contributor

ixmatus commented Dec 23, 2015

Took a while to track this one down but our S3 URLs were being rejected by AWS because the host header was not being signed! I took a hint from the base function in constructing the rqHeaders request object.

No included tests, I didn't see any tests for this specific functionality, but I did hand test it on our own production software and it fixes the regression.

@brendanhay

This comment has been minimized.

Show comment
Hide comment
@brendanhay

brendanhay Dec 31, 2015

Owner

Apologies for the late reply - can you add the required lens (%~) re-export to Network.AWS.Prelude on your branch so CI can build?

Owner

brendanhay commented Dec 31, 2015

Apologies for the late reply - can you add the required lens (%~) re-export to Network.AWS.Prelude on your branch so CI can build?

@ixmatus

This comment has been minimized.

Show comment
Hide comment
@ixmatus

ixmatus Dec 31, 2015

Contributor

@brendanhay no worries! I've pushed the added export. If that's a change in another branch you'd prefer me to integrate, I can do that but I didn't see any newer updates to the develop branch.

Contributor

ixmatus commented Dec 31, 2015

@brendanhay no worries! I've pushed the added export. If that's a change in another branch you'd prefer me to integrate, I can do that but I didn't see any newer updates to the develop branch.

brendanhay added a commit that referenced this pull request Jan 4, 2016

Merge pull request #264 from plumlife/develop
Host header is a requirement for V4 request signing

@brendanhay brendanhay merged commit 4de27e1 into brendanhay:develop Jan 4, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@brendanhay

This comment has been minimized.

Show comment
Hide comment
@brendanhay

brendanhay Jan 4, 2016

Owner

Thanks!

Owner

brendanhay commented Jan 4, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment