Host header is a requirement for V4 request signing #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the late reply - can you add the required lens |
|
@brendanhay no worries! I've pushed the added export. If that's a change in another branch you'd prefer me to integrate, I can do that but I didn't see any newer updates to the develop branch. |
brendanhay
added a commit
that referenced
this pull request
Jan 4, 2016
Host header is a requirement for V4 request signing
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a while to track this one down but our S3 URLs were being rejected by AWS because the
hostheader was not being signed! I took a hint from thebasefunction in constructing therqHeadersrequest object.No included tests, I didn't see any tests for this specific functionality, but I did hand test it on our own production software and it fixes the regression.