Strip 'Expect' header when presigning URLs #444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363.
This is more or less the simplest thing that can be done to make
pre-signed PUT urls work, and it exposes the header transformation
at the lowest level, so that it's possible to build some other
behavior on top of that. However, this is neither as targeted nor
as flexible as the solutions proposed in the issue.
This is the approach from the workaround I posted on that issue, but simpler because I didn't thread the transformation of headers all the way up through the layers. I'm submitting this for feedback; happy to rework this branch to make this more robust, flexible, or whatever.
I've tested it by running the following: