Derive FromJSON for BucketName #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to pull a BucketName from a config file, and since BucketName already supports FromXML it seemed reasonable to support FromJSON
|
Thanks for the PR - the generator doesn't need to be run as this module is hand-rolled and simply imported by the generated code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to pull a BucketName from a config file, and since BucketName already supports FromXML it seemed reasonable to support FromJSON
I didn't actually test this. I'm not sure how to run the generator, but from the READMEs it seemed like continuous integration would run the generator for me anyway, and I figured I could look at that.