Additional Glacier Required Fields #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are apparently not marked as required in the service file, but they are marked as required in the docs for these things, e.g. https://docs.aws.amazon.com/amazonglacier/latest/dev/api-multipart-initiate-upload.html I don't know the difference between marking a field as required in the shapes of gen/annex/foo.json, vs marking it as required in the typeOverrides of gen/config/foo.json. This current approach seems to give the desired effect, though. There's likely plenty of other request types where the service files are not entirely accurate, but I just did this for the types I'm currently working with (the ones necessary to do multipart uploads).
typeOverrides are more robust in the presence of service description updates, ie. new fields being added which would simultaenously require the annex to be updated in step. They unfortunately affect the field/parameter ordering of the generated types and constructors, do to being appended to the set of inputs. Closes #469
brendanhay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #469