Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aeson-2.0 #713

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Support aeson-2.0 #713

merged 1 commit into from
Nov 26, 2021

Conversation

endgame
Copy link
Collaborator

@endgame endgame commented Nov 25, 2021

Closes #680 .

Tests done:

  • Built repo with constraints: aeson ^>= 2.0
  • Built repo with constraints: aeson ^>= 1.5
  • Write a test program and ensure HashedBody still works

Copy link
Collaborator Author

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sagemaker-runtime will need regenerating but you prefer to do those in other branches.

configs/services/sagemaker-runtime.json Show resolved Hide resolved
@endgame
Copy link
Collaborator Author

endgame commented Nov 26, 2021

I banged together a test program that successfully uploaded a HashedBody to S3, so I'm pretty sure I didn't break anything. @brendanhay OK to merge?

@brendanhay
Copy link
Owner

brendanhay commented Nov 26, 2021 via email

@endgame endgame merged commit 4c03b5b into brendanhay:main Nov 26, 2021
@endgame endgame deleted the aeson-2.0 branch November 26, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aeson ^>= 2.0 support
2 participants