Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colons in error headers #830

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Colons in error headers #830

merged 2 commits into from
Oct 25, 2022

Conversation

endgame
Copy link
Collaborator

@endgame endgame commented Oct 24, 2022

Fixes #808

@endgame
Copy link
Collaborator Author

endgame commented Oct 24, 2022

@debug-ito: Can you please test whether this works for you? It looked good to me in a REPL.

@debug-ito
Copy link

Thanks. I'll try it.

@debug-ito
Copy link

I'm testing this branch, but the compiler complains that there is no FromKeys data constructor in Amazonka module. However, it's described in this document https://amazonka.brendanhay.nz/docs/libZSamazonkaZSamazonka/Amazonka.html#t:Credentials

Is there any up-to-date online documents on amazonka API?

@endgame
Copy link
Collaborator Author

endgame commented Oct 24, 2022

Unfortunately the CI job which updates that documentation site is broken, something to do with credentials. Only @brendanhay can fix that.

A migration guide for the authentication subsystem is in amazonka's CHANGELOG.md, and you can see the auth modules in lib/amazonka/src/Amazonka/Auth/. The relevant parts are re-exported from module Amazonka.Auth.

@debug-ito
Copy link

Thanks! The migration guide is very helpful.

@debug-ito
Copy link

I used IoT._ResourceNotFoundException and it successfully caught the exception. #808 is fixed.

@endgame endgame merged commit 17e377b into brendanhay:main Oct 25, 2022
@endgame endgame deleted the colons-in-error-headers branch October 25, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot catch with IoT._ResourceNotFoundException
2 participants
@endgame @debug-ito