Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude iPad from mobile view #21

Open
keilmillerjr opened this issue May 24, 2011 · 16 comments
Open

Exclude iPad from mobile view #21

keilmillerjr opened this issue May 24, 2011 · 16 comments

Comments

@keilmillerjr
Copy link

There is no way to have the iPad not load a mobile view and mobile CSS!

The iPad is a mobile device and includes the string mobile in the user agent string. Because of this, even if I have removed the ipad string from MOBILE_USER_AGENTS, mobile-fu will still recognize it as a mobile device.

The problem is that some web sites work well and are designed to work well with the iPad and other tablet devices. These types of mobile devices have enough screen real estate where some sites would work well, and others wouldn't.

This issue needs to be addressed! The issue has already been commented on in the commits -> comments section by 3 people starting in May 2010!

  • tsmango commented on brendanlim/mobile-fu May 17, 2010
  • brendanlim commented on brendanlim/mobile-fu April 07, 2010
  • kineticac commented on brendanlim/mobile-fu April 06, 2010

Possible resolution

Allow an option to disable tablets from the mobile user agents or perhaps even better: create a MIME type of :tablet and have tablets have their own views/css.

Please let me know what your thoughts are. I only write this because I think mobile-fu is a great plugin and would like to see it improve (and see it made usable).

Thanks,

Keil

@benlangfeld
Copy link

If you could please refile this issue on my fork, I should be able to sort something out.

@rodgersn
Copy link

rodgersn commented Aug 5, 2011

Guys, how did this go? Has this been merged into the main fork?

@benlangfeld
Copy link

This repo is inactive and I've not received anything to my fork.

@brendanlim
Copy link
Owner

Sorry, I'll be working on merging your fork in this weekend.

@brendanlim brendanlim reopened this Aug 6, 2011
@ippa
Copy link

ippa commented Oct 5, 2011

I came here to open a ticket about the exact same thing. I don't want to serve a "crippled" mobile-view to iPads which render normal websites just fine.

I like the view.tablet idea too though if one Would like to serve something special to a pad.

@flippyhead
Copy link

There should be a custom excludes one can set maybe

@oceanshq
Copy link

oceanshq commented Nov 6, 2011

Agree with flippyhead, would be nice to enable custom excludes.

@keilmillerjr
Copy link
Author

Any updates on this issue? Is mobile-fu still in development?

@benlangfeld
Copy link

@tuscanidream: Not at this repository, no. I am accepting pull requests at benlangfeld/mobile-fu (this is where the gem is published from) and would welcome this as a feature submission.

@SentulAsia
Copy link

added the TABLET_USER_AGENTS but this is my first time working on gem, can some body check my code if it is correct?

@keilmillerjr
Copy link
Author

I haven't tried it yet, but thanks @atuk84 for the addition. :)

@jpmcgrath
Copy link

I have need of this feature as well. Is anything happening with it? Can I help in some way to move this forward?

@SentulAsia
Copy link

download the latest mobile-fu gem... its there...

@benlangfeld
Copy link

@jpmcgrath This repo is unmaintained. The gem includes this.

@jpmcgrath
Copy link

Thanks @atuk84 @benlangfeld Amazingly quick respnse :-)

I had just noticed that this didn't seem to be the active repo, thanks for the confirmation. I will check out the new version now.

Cheers.

grncdr referenced this issue in StemboltHQ/mobile-fu Mar 5, 2013
@benlangfeld
Copy link

This project is abandoned. Please see the active fork at http://github.com/benlangfeld/mobile-fu. Please test with the released gem and master branch of the new home for the project, and file an issue on the other repo if you still have problems.

See #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants