Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Made a number of minor improvements:
- Permit input from a file provided as an argument, maintaining the ability to input via STDIN - Transparently permit input of a gzipped FASTQ, when provided with a FASTQ filename ending in '.gz' - Add useful '__future__' imports - Refactor print statements to use the new syntax and use '.format' - Enforce PEP8 compliance - Change exit code upon error to a non-zero value (1) - Minor refactoring, removing redundant traces - Add an appropriate shebang - Revise internal documentation, adding common use-cases
- Loading branch information
Showing
1 changed file
with
58 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95adaa7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit causes
guess-encodying.py
to output the first two columns in square brackets. Like thisBefore, it would have been
This seems like a bug. Am I wrong?
95adaa7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @cviner
95adaa7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-wb Thanks for catching that difference. I apologize for this oversight—I did not notice it before.
This is due to my neglecting to join the list of valid guessed encodings, as was done in the previous version. Another difference is that, previously, the min/max were returned as two comma-delimited values within parentheses, while they are now output as individual columns.
I actually find the current version more sensible. Previously, this script could return a variable number of columns, depending upon the guessed encodings. In this version, the set of all possible encodings is provided as a list, and the output always consists of exactly three columns. This simplifies downstream parsing.
Nonetheless, I am happy to immediately implement the previous behavior, if you think that is important.
95adaa7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Sounds okay, but I think it would be nice to take out the array so that the column is easier to parse. For example you could join the elements with underscores.
95adaa7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to pull out the first column with
cut -f1
which is why the array in the first column is slightly annoying.