make method public

brettclanton001 · Feb 18, 2017 · 0e3de53 · 0e3de53
1 parent 2ca8adc
commit 0e3de53
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/app/jobs/update_exchange_rate_job.rb b/app/jobs/update_exchange_rate_job.rb
@@ -2,6 +2,6 @@ class UpdateExchangeRateJob < ApplicationJob
   queue_as :exchange_rate
 
   def perform(*args)
-    ExchangeRateService.send :fetch_external_data
+    ExchangeRateService.fetch_external_data
   end
 end
diff --git a/app/services/exchange_rate_service.rb b/app/services/exchange_rate_service.rb
@@ -10,14 +10,6 @@ def current_price(currency='usd')
     external_data[currency]
   end
 
-  private
-
-  def external_data
-    cache = get_cache
-    return cache if cache_valid?(cache)
-    fetch_external_data
-  end
-
   def fetch_external_data
     data = {}
 
@@ -33,6 +25,14 @@ def fetch_external_data
     data
   end
 
+  private
+
+  def external_data
+    cache = get_cache
+    return cache if cache_valid?(cache)
+    fetch_external_data
+  end
+
   def cache_valid?(cache)
     cache.present? and cache['updated_at'] > Time.now - CACHE_TIMEOUT
   end

diff --git a/lib/tasks/exchange_rate.rake b/lib/tasks/exchange_rate.rake
@@ -2,6 +2,6 @@ namespace :exchange_rate do
 
   desc "fetch and cache current exchange rate"
   task update: :environment do
-    ExchangeRateService.send :fetch_external_data
+    ExchangeRateService.fetch_external_data
   end
 end