Commands can have several parameters #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brett,
That is the new version of my pull request, to add the ability to have several parameters for commands you add to the bot.
"p Hello world!".match(/^p\s+(.*)$/).captures # => ["Hello world!"]
shows the idea). By the way, the piece of code to scan the message is a bit cleaner.Here's an example of command with this feature:
So that could be used like this:
rand_in 30 50 # => 42
.I think it is useful (for a project, I use something like
email recipient@somewhere.com Body of the message...
), and in my opinion, adding groups to the regex makes the command more readable and easier to handle.Thanks,
Vivien.