-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mount #1
Conversation
This allows automatically adjusting the symlink in $WINEPREFIX/dosdevices
Wine apparently needs a symlink to the image to get the necessary CD information If the drive the mountpoint is set to is "E:", then there will be one symlink $WINEPREFIX/dosdevices/e: pointing to the mountpoint and another $WINEPREFIX/dosdevices/e:: pointing to the image This is the same as when it is a physical drive, i.e. d:: points to /dev/sr0
… executions on every right click are not a good idea
Wow. Thank you :) I need some time to examine and test your code. |
You may not want to add 19a9a83 (it is not related to my addition), but for me running losetup with sudo didn't work properly so I removed it since the gained functionality was nice but not neccessary for me. I noticed this method was being called way too often, though. Since it spawns a new process every time this should be reduced. |
I test mount improvements and seems it works fine. Good job! I'l gladly include your code to my source tree. Thanks :) btw: If you wish, you can send to me information which can be placed in q4wine's about dialog. Well, I'l revert 19a9a83 changes. I knew it is a horrible dirty hack, but I can't find any other way to get information from loop device. I plan to add cdemu (http://cdemu.org) support and use it as default mount backend. |
The commits create new symlinks when mounting$WINEPREFIX/dosdevices/$ {DRIVE}: pointing to the mountpoint and $WINEPREFIX/dosdevices/$ {DRIVE}:: pointing to the Image file (not the double colon).
Apparently this is needed so that the images are recognised as a proper cd/dvd drive.
This also adds on column to the database which determines which wine drive to use for the mounted images (configurable in the GUI)