Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples using additional modules in separate files do not work on mybinder #3

Closed
mstimberg opened this issue May 24, 2018 · 2 comments

Comments

@mstimberg
Copy link
Member

Examples like this one do not currently work on mybinder because they expect to import a module from a file in their current directory. Given that this module (e.g. params.py ) has been translated to an .ipynb file as well, it cannot be imported.

I guess the easiest fix would be to add a special comment like # NO_NOTEBOOK to the top of such files and copy them over verbatim as .py files?

@thesamovar
Copy link
Member

We could modify the way the binder script works so that it copies all files across as well as converting into ipynb?

@mstimberg
Copy link
Member Author

Good point, that sounds like a better solution given that we don't have to change the example files. I initially had in mind to also remove the "Launch on binder" button on files like params.py in the Brian documentation, but this is just a tiny detail and probably not worth adding a cryptic comment to the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants