Avoid that formatted strings discard units of quantities #1377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big string formatting unification in d3ae592 introduced a regression in a few places, because the default formatting for quantities used in f-strings or
.format
is to display it as a floating point number, discarding its units:In most places, I worked around this by using something like
"... t={start!s}"
to manually force a conversion to a string, but I think it would be better if we changed quantities' default for "formatting without format spec" (which would also be more consistent with a simpleprint(start)
). Luckily, we can do this easily using the__format__
function. With this PR, both print statements above give the same output.