Cython: Include support code in before_run block #1428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support code has to be included for
before_run
blocks, otherwise variables needed for functions that refer to namespaces (e.g.TimedArray
) will not be correctly defined. This is a simple fix, in the longer run we should think about custom functions, namespaces etc. inbefore_run
block. Currently, these blocks do not actually need any of all this, since they don't run user-defined code (but potentially that might change in the future?).Fixes #1427, see https://brian.discourse.group/t/time-dependend-input-in-equation-vs-parameter/753/5 for example code that failed previously.