include user headers in before/after blocks #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clashes with std::function
thesamovar
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
after_runandbefore_runcode blocks (only used in a few templates) were including support code, but not user-provided header files. This means that user-defined functions that relied on external header files were not compiling correctly. The fix is rather trivial and has considerably fewer lines of code than the new test 馃槉See https://brian.discourse.group/t/how-to-use-prefs-devices-cpp-standalone-extra-make-args-unix/783 for the discussion that triggered this PR (and thanks to @wxie2013 for reporting it!).