Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add isort #1444

Merged
merged 7 commits into from Nov 22, 2022
Merged

ci: add isort #1444

merged 7 commits into from Nov 22, 2022

Conversation

oleksii-leonov
Copy link
Contributor

@oleksii-leonov oleksii-leonov commented Nov 19, 2022 •
edited

Adding isort to pre-commit and .devcontainers. GitHub actions run pre-commit, so no changes are needed there.
Related to #1295, #1435.

@oleksii-leonov oleksii-leonov marked this pull request as ready for review November 20, 2022 00:58
mstimberg
mstimberg approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@mstimberg mstimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, looks good to me! I did some minor changes, and I am only waiting for all tests to run through before doing the merge.

@mstimberg mstimberg merged commit 761c9c0 into brian-team:master Nov 22, 2022
@mstimberg mstimberg mentioned this pull request Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstimberg mstimberg mstimberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oleksii-leonov @mstimberg