Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementiation of Spreizer_et_al_2019: an anisotropic network #1447

Merged
merged 9 commits into from Aug 1, 2023

Conversation

arashgmn
Copy link
Contributor

Reproduction of Fig. 2 (b and c) of Spreizer et al. 2019 in Brian:

Spreizer S, Aertsen A, Kumar A. From space to time: Spatial inhomogeneities lead to the emergence of spatiotemporal sequences in spiking neuronal networks. PLOS Computational Biology. 2019;15(10):e1007432. doi:10.1371/journal.pcbi.1007432

Requirements:

  • Brian
  • numpy
  • matplotlib
  • noise: For setting up the Perlin landscape.

Happy new year and merry Christmas!

@mstimberg
Copy link
Member

Hi @arashgmn, many thanks for this contribution! I'll need a bit of time to look through it in detail and figure out the best way to integrate the generated figures, but it should be a very nice addition to our docs 🙏

Provide pre-generated noise directly here as files
@mstimberg
Copy link
Member

Thanks again for the contribution and apologies that it took me ages to actually look into this in detail. I spent an unreasonable amount of time to get this to be more similar to the figure from the original paper. But of course, thanks to your animation, it is much better than the original plot now 😄

Here's what it looks like now:
anim

Are you happy with my code changes and the new figure? Apologies for the re-formatting, it makes the changes harder to see. I realized too late that my editor was configured to run the black formatter over everything. I also tok the liberty to copy the pre-generated noise files directly here, this should make it easier for anyone using the files.

@arashgmn
Copy link
Contributor Author

Hi @mstimberg,
Thanks for taking care of the plots! They look amazing and I'm totally happy with the changes :)

arashgmn

This comment was marked as duplicate.

Copy link
Contributor Author

@arashgmn arashgmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seem good to me!

Copy link
Member

@mstimberg mstimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🎉
Thanks again!

@mstimberg mstimberg merged commit 4fb9c34 into brian-team:master Aug 1, 2023
2 of 8 checks passed
@mstimberg
Copy link
Member

It's online now: https://brian2.readthedocs.io/en/latest/examples/frompapers.Spreizer_et_al_2019.Spreizer_et_al_2019.html

(currently only in the "latest" version of the documentation, it will appear in the default "stable" version with the next release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants