Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the Izhikevich_2007 example neuron model bug #1476

Closed
max-talanov opened this issue Jun 28, 2023 · 4 comments
Closed

the Izhikevich_2007 example neuron model bug #1476

max-talanov opened this issue Jun 28, 2023 · 4 comments

Comments

@max-talanov
Copy link

Dear all.
Thank you for the great impact involved in creation of the brian2 and documentation and examples.
But I have found the bug in the example Izhikevich_2007:
The line 55 contains the formula of the Neuron:
dv/dt = (ge * (Ee-vr) + El - v) / taum : volt
While original example STDP contains the following formula:
dv/dt = (ge * (Ee-v) + El - v) / taum : volt
And the original article of Song, Miller and Abbott (2000) page 25:
image
That makes much more sense as ge influence is multiplied to Ee - current voltage rather than reset voltage constant.
In the scope of the Izhikevich_2007 example the bug possibly does not make much difference, but if one tries to reuse the code in the network with combination of STDP and static synapses STDP synaptic influence could be much lower than static.
Could you please fix this minor issue in the example.
Thank you so much in advance.
Dr. Max Talanov.

@DHRUVJ2003
Copy link
Contributor

Hello,
I am interested in solving this issue. Can you please state how can I reproduce the issue? Will changing the formula in Izhikevich_2007 solve the issue??
I am new to open source and to brian as well.

Thanks

@max-talanov
Copy link
Author

Hello.
Yes please update the formula.

@mstimberg
Copy link
Member

Closed via #1485 – thanks to @max-talanov for reporting and to @DHRUVJ2003 for fixing 🙏 .

The updated example is here (will be in the "stable" version of the docs with the next release): https://brian2.readthedocs.io/en/latest/examples/frompapers.Izhikevich_2007.html

@DHRUVJ2003
Copy link
Contributor

Thank you 🙏 ..... It is an honour to contribute to brian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@max-talanov @mstimberg @DHRUVJ2003 and others