Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Remove packaged GeNN #78

Merged
merged 12 commits into from
Nov 23, 2018
Merged

[MRG] Remove packaged GeNN #78

merged 12 commits into from
Nov 23, 2018

Conversation

mstimberg
Copy link
Member

As discussed in #53, this removes our fancy "pre-compile GeNN libraries and ship them with BrianGeNN" approach. Users should install GeNN manually and then install Brian2GeNN from source via pip.

Closes #53

@mstimberg
Copy link
Member Author

@tnowotny , @thesamovar this is fine with you, right? After merging, I think it would be time to do the 1.2 release (given that we only release the source package, doing the release will be straight-forward...).

I think I'll also move our existing conda packages to an archive label or something like that. This will prevent users from installing an outdated version by following older installation instructions.

@mstimberg
Copy link
Member Author

PS: Don't worry about the build failure, we test everything twice (once on the branch and once after merging -- given that nothing else changed on the master branch, the two are perfectly identical) and one of the two ran fine, the other took to long for the appveyor timeout.

@tnowotny
Copy link
Contributor

Yes, as discussed, I think this is the most sensible option. I would hope it leads to a lot less trouble with compiler and library versions etc
so, ok to go forward from my perspective.

@thesamovar
Copy link
Member

Yeah, it's a shame to not have it be one line install, but that's kind of unrealistic anyway and we don't want to have a heavy maintenance burden on this.

@mstimberg mstimberg merged commit 156ac49 into master Nov 23, 2018
@mstimberg mstimberg deleted the remove_packaged_genn branch November 23, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants